Set/clear autosave based on cookie.#2
Open
ctbarna wants to merge 3 commits into
Open
Conversation
There is a cookie set on the client side that is modified on the server side upon successful save.
Django appears to be naive about request cookies (not sure if it's django or the way that cookies work in general). We need to explicitly set the path to the referer, otherwise we end up with two cookies called "autosave_success."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more likely use case than a user accidentally closing a window and losing work is that we have a server error after the form has already been submitted. At the point the server error comes through, the autosave will already have been erased.
This change introduced a cookie that is set on the client side via javascript and then modified upon successful save. If the save succeeds, the autosave and the cookie are erased.