Skip to content

fix(cmake): quote NuGet install output#264

Open
Osraka wants to merge 1 commit into
thebrowsercompany:mainfrom
Osraka:osraka/fix-nuget-output-quoting
Open

fix(cmake): quote NuGet install output#264
Osraka wants to merge 1 commit into
thebrowsercompany:mainfrom
Osraka:osraka/fix-nuget-output-quoting

Conversation

@Osraka
Copy link
Copy Markdown

@Osraka Osraka commented May 13, 2026

Summary

  • quote NUGET_INSTALL_OUTPUT before splitting it into CMake list lines
  • prevents string(REPLACE) from receiving too few arguments when the NuGet output is empty or expands unexpectedly
  • keeps the existing filtering behavior for Successfully installed / already installed messages

Fixes #237.

Testing

  • git diff --check
  • Not run: full CMake build requires the Windows SDK / Windows toolchain environment described in README.md and AGENTS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build] wrong syntax in nuget.cmake

1 participant