-
Notifications
You must be signed in to change notification settings - Fork 138
Fix multiarch + Add bash_unit for testing #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7eccae7
to
40b1395
Compare
da453ba
to
a6c958e
Compare
a7eaaaa
to
4b05d20
Compare
bc8e0f7
to
2f9047b
Compare
* Lint symlink for extensions directories
…i` instead of `/var/lib/php/modules/${PHP_VERSION}/registry/*`
* Allow to change related repository with ARG * Allow to suffix tag with ARG * Allow to change FROM_IMAGE with ARG (to allow some optimisation in docker bake with precedences) * Use ARG instead of `Dockerfile.${VARIANT}.node{10,12,14,16}` files * Use `SHELL ["/bin/bash", "-o", "pipefail", "-c"]` mode for Dockerfile * Specify version of Dockerfile avec v1 `#syntax=docker/dockerfile-upstream:1` * Reduce `RUN` steps * Upgrade tini to v0.19 * Fix supercronic installation * Fix npm version built in slim mode * Add .dockerignore to optimise build time and memory
…s (too long to build)
8c3a1de
to
61e03be
Compare
61e03be
to
259bd56
Compare
8ffa35f
to
a6363bf
Compare
a6363bf
to
68e5d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix multi arch troubles and lot of related things (becareful : it's a risky PR, especialy,
tini
is removed and it was directly related to the entrypoint).This PR fixes/implements :
Checklist
TODO
Theses changes are not included in this PR (already so big) but FYI :