Skip to content

Fix multiarch + Add bash_unit for testing #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 21, 2022
Merged

Fix multiarch + Add bash_unit for testing #325

merged 20 commits into from
Sep 21, 2022

Conversation

mistraloz
Copy link
Collaborator

@mistraloz mistraloz commented Aug 30, 2022

Summary

Fix multi arch troubles and lot of related things (becareful : it's a risky PR, especialy, tini is removed and it was directly related to the entrypoint).

This PR fixes/implements :

Checklist

  • I followed the guidelines in CONTRIBUTING guide
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

TODO

Theses changes are not included in this PR (already so big) but FYI :

  • more work is required to speed up build and test (especialy for ARM)
  • some changes should be required for optimise building stages in ci (test one version before all other to avoid spaming, synchronize cache between step... or any other idea to allow more accurate testing)
  • Some php extensions are removed into arm because the build time is too long for them : swoole, rdkafka, ev and snmp.
  • Tini is disabled (as hot fix) because it's does work properly in arm build. It's may a good idea to double check if there is a breaking change (PR Run Apache2 in background #215 may help to find a smart fix).
  • There is too much extensions onto fat images, and too much variants. We should find a way to avoid that to allow a more new features and an easier maintenance.

@mistraloz mistraloz force-pushed the hotfix/multiarch branch 4 times, most recently from 7eccae7 to 40b1395 Compare August 30, 2022 14:21
@mistraloz mistraloz force-pushed the hotfix/multiarch branch 15 times, most recently from da453ba to a6c958e Compare September 1, 2022 17:42
@mistraloz mistraloz changed the title Hotfix push with patched version Fix multiarch + Add bash_unit for testing Sep 1, 2022
@mistraloz mistraloz force-pushed the hotfix/multiarch branch 9 times, most recently from a7eaaaa to 4b05d20 Compare September 5, 2022 14:04
@mistraloz mistraloz force-pushed the hotfix/multiarch branch 4 times, most recently from bc8e0f7 to 2f9047b Compare September 19, 2022 13:14
* Lint symlink for extensions directories
…i` instead of `/var/lib/php/modules/${PHP_VERSION}/registry/*`
* Allow to change related repository with ARG
* Allow to suffix tag with ARG
* Allow to change FROM_IMAGE with ARG (to allow some optimisation in docker bake with precedences)
* Use ARG instead of `Dockerfile.${VARIANT}.node{10,12,14,16}` files
* Use `SHELL ["/bin/bash", "-o", "pipefail", "-c"]` mode for Dockerfile
* Specify version of Dockerfile avec v1 `#syntax=docker/dockerfile-upstream:1`
* Reduce `RUN` steps
* Upgrade tini to v0.19
* Fix supercronic installation
* Fix npm version built in slim mode
* Add .dockerignore to optimise build time and memory
@mistraloz mistraloz force-pushed the hotfix/multiarch branch 2 times, most recently from 8c3a1de to 61e03be Compare September 19, 2022 16:11
@mistraloz mistraloz merged commit 2a39e59 into v4 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant