-
Notifications
You must be signed in to change notification settings - Fork 101
Allow callable() as field deferring mechanism #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
============================================
- Coverage 95.72% 94.86% -0.87%
- Complexity 1773 1838 +65
============================================
Files 154 175 +21
Lines 4586 5000 +414
============================================
+ Hits 4390 4743 +353
- Misses 196 257 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@oprypkhantc so I've merged this, but am getting an error locally.
Any ideas on this? |
@oprypkhantc ^^ |
Sorry, I somehow missed all GitHub notifications from that time it seems 🤔 It's hard to tell from that trace, as there's no ->current() call on that line. I did also update to dev-master and am not getting any errors 👀 |
Yeah, it seems that for some reason graphqlite created @oojacoboo can you share the graphql query and types definition which fail with the current master? |
book(id: "%s") {
id
authors {
addresses {
type {
key
}
}
}
} This call in the stack looks particularly interesting:
So, on line 63 of |
@oojacoboo can you share code of the "address type" graphql type? Is it return any callable in some field? |
@andrew-demb sure - quite simple class. No callables. #[GraphQLite\Type]
#[GraphQLite\Input]
class AddressType
{
public const string BILLING = 'billing';
public const string CURRENT = 'current';
public const string LEGAL = 'legal';
public const string MAILING = 'mailing';
public const string PHYSICAL = 'physical';
#[GraphQLite\Field(for: 'AddressTypeInput')]
protected string $key;
public function __construct(string $key)
{
$this->key = $key;
}
public function __toString(): string
{
return $this->getKey();
}
#[GraphQLite\Field(outputType: 'ID!')]
public function getKey(): string
{
return $this->key;
}
} |
@oojacoboo I'm out of ideas. Let's revert then until we find the reason to not lock releases. |
@oojacoboo Could it be that you updated other dependencies alongside |
Closes #738