Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake modular installation #185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Haranoi17
Copy link

@Haranoi17 Haranoi17 commented Nov 19, 2022

I'm not sure weather this change helps or interrupts.

It's definitely not finished and needs work but I require some help with that since I'm still new to CMake.

Main reason I made these changes was to build my application in elegant way.
I wanted to use your "application" class as starting point but I didn't want to wire CMakes to build directory.

After introducing changes, building and installing.
Integration with imgui-node-editor looks like this.
image
image

Unfortunately I couldn't come up with solution to PUBLIC include directories.
From my understanding mere linking to imgui_node_editor::imgui_node_editor should make them visible
for the project but It doesn't. Hence ${CMAKE_INSTALL_PREFIX}/../imgui_...

@thedmd thedmd force-pushed the develop branch 2 times, most recently from 483a8f1 to 7d0f315 Compare May 2, 2023 15:25
@thedmd thedmd force-pushed the develop branch 2 times, most recently from 6e1cade to 01fa1b9 Compare September 1, 2023 13:59
@thedmd thedmd force-pushed the develop branch 3 times, most recently from bd1924c to b302971 Compare July 21, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant