Allow a context to defined in the ImGui config header. #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found it useful to have control over the modifiers and/or type of the internal context
s_Editor
, which is defined inimgui_node_editor_api.cpp
.In my case, it's important to make the context
thread_local
for an application that has many instances of the the node editor all running in different threads of the same process, otherwise, thestatic
context is shared and things get ugly.I propose that the standard ImGui approach is adpoted, whereby defining your own
GImGuiNodeEditor
in your standard ImGui config header will enable you to override the context.With this, to make the context
thread_local
we can definein our ImGui config header with the
extern
global referring to some instance ofax::NodeEditor::Detail::EditorContext
somewhere in the program.