-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagram of installer-based provisioning with PXE boot #3304
Add diagram of installer-based provisioning with PXE boot #3304
Conversation
The PR preview for 4254ddc is available at theforeman-foreman-documentation-preview-pr-3304.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments for the "Create host in Foreman" part.
One question: Right now, the happy path workflow is described. Do we want to also show paths when, for example, DHCP reservations fail? IMO, it would make the diagram crazy big, but it's something to think about.
The diagram is already crazy big. I think we should go with the happy path only. We're not writing a design specification, we're trying to familiarize the user with the basic workflow. |
ed26663
to
ca9e62d
Compare
I have enabled the display of Puppet parts because in upstream that's welcome. Also cleaned up the style of the diagram and rebased the PR. FYI I have kept 3 notes over Host that mark the status of the host at the given times. I think that it's the appropriate use of the notes. |
@asteflova Can you please review the diagram for style and give it a final ack if okay? I tried to incorporate Avital's comments from #3309 and I have provided a preview inside the docs just to check that the text in the diagram will be readable once included. The module that provides the preview will not be merged at this time. |
Hi @Lennonka, to be honest, I wasn't going to review. I can't think of anything that I could review in terms of |
@asteflova Does it mean that I can set the |
Ah, now I see that Avital reviewed another PR, not this one.
I was under the impression that your goal was to create the diagrams but not add them to any guides just yet. Has that changed? I can now see it included in the guide builds, including the d/s Satellite build. |
@asteflova Avital has asked me to provide a temporary preview so that we can check that the text in the diagram is readable. This will not be included in the merge. |
Thanks for explaining! In that case, I'd say there is nothing to review in terms of 'style review'. |
71e84e8
to
ac64275
Compare
ac64275
to
4254ddc
Compare
What changes are you introducing?
Adding a sequence diagram of installer-based provisioning with PXE boot. Using PlantUML to build the diagram.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Preparation for improvements of Provisioning hosts. The diagram will be used later to explain the workflow of the provisioning method.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A