add GHA based tests #939
Merged
add GHA based tests #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
May 8, 2024
Comment on lines
+27
to
+33
| - ruby: '2.7' | ||
| puppet: '7.0' | ||
| - ruby: '3.0' | ||
| puppet: '7.0' | ||
| - ruby: '3.2' | ||
| puppet: '8.0' |
There was a problem hiding this comment.
I copied this from kafo and do not remember why we had added 3/7 here, but I am sure there was a reason :D
There was a problem hiding this comment.
On EL9 we run Ruby 3, but often with Puppet 7. It would be even better if we installed actual AIO Puppet packages and avoided installing Puppet via bundler altogether. Our current Gemfile doesn't support that, but we could special case it with PUPPET_VERSION=system. But let's only do that in develop and cherry pick this PR just to our stable branches.
evgeni
force-pushed
the
gha
branch
2 times, most recently
from
5f7e8e0
to
530fda2
Compare
ekohl
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.