Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36940 - Add necessary migration for host_config tftp directory #949

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sbernhard
Copy link
Contributor

@sbernhard sbernhard commented May 31, 2024

The migration is necessary as part of the puppet_foreman_proxy change in theforeman/puppet-foreman_proxy#821

Belongs to the SecureBoot story: theforeman/foreman#9864

@ehelms
Copy link
Member

ehelms commented May 31, 2024

A migration spec for this would be great to have. Example: https://github.com/theforeman/foreman-installer/blob/develop/spec/migrations/20240328125552_reset_puppetserver_ciphers_spec.rb

@sbernhard sbernhard force-pushed the fix_36940 branch 2 times, most recently from c3e3495 to f115512 Compare May 31, 2024 14:14
@goarsna
Copy link

goarsna commented Jul 16, 2024

FYI: @nofaralfasi and I had a discussion last week that resulted in some changes we want to implement on the Smart Proxy side which are summarized in the Smart Proxy PR. These changes also will affect this PR. Further updates will follow soonish / in the upcoming weeks (as soon as I have time to work on this again).

@goarsna
Copy link

goarsna commented Aug 5, 2024

One outcome of the above mentioned discussion was that the Bootloader Universe should not be configurable. Instead it will be a fixed folder inside the TFTP root that is created automatically during installation / upgrade. The other agreement was, that the Host Config directory will be written with a dash. Both have now been applied to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants