Fixes #32599 - prevent to read facts without permissions #2076
Annotations
10 errors
Run rake test:units:
test/unit/puppet_fact_importer_test.rb#L672
Failure: test_0002_importer imports structured facts
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
test/unit/puppet_fact_importer_test.rb:31:in `import'
test/unit/puppet_fact_importer_test.rb:23:in `block in <class:PuppetFactImporterTest>'
|
Run rake test:units:
test/unit/puppet_fact_importer_test.rb#L672
Failure: test_0001_importer imports everything as strings
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
test/unit/puppet_fact_importer_test.rb:31:in `import'
test/unit/puppet_fact_importer_test.rb:17:in `block in <class:PuppetFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0001_fires a host_facts_updated event on success import
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:363:in `block (3 levels) in <class:HostFactImporterTest>'
test/unit/host_fact_importer_test.rb:358:in `block (2 levels) in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0009_domain updated from facts
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:73:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0030_host hostgroup updated from facts
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:303:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0014_should import facts idempotently
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:121:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0023_taxonomies from facts override already existing taxonomies in hosts
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:231:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0028_operatingsystem not updated from facts when ignore_facts_for_operatingsystem false
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:277:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0010_domain not updated from facts when ignore_facts_for_domain false
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:81:in `block in <class:HostFactImporterTest>'
|
Run rake test:units:
test/unit/host_fact_importer_test.rb#L672
Failure: test_0026_operatingsystem from facts resets medium if medium is for different OS
ActiveRecord::StatementInvalid: PG::AmbiguousColumn: ERROR: column reference "name" is ambiguous
LINE 1: SELECT "name", "fact_values"."value", "fact_values"."id" FRO...
^
app/services/fact_importer.rb:140:in `update_facts'
app/services/fact_importer.rb:42:in `block in import!'
app/services/fact_importer.rb:40:in `import!'
app/services/host_fact_importer.rb:27:in `block in import_facts'
lib/foreman/telemetry_helper.rb:28:in `telemetry_duration_histogram'
app/services/host_fact_importer.rb:26:in `import_facts'
test/unit/host_fact_importer_test.rb:254:in `block in <class:HostFactImporterTest>'
|
Loading