Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show complete hostgroup name in host overview and table #10244

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kmalyjur
Copy link
Contributor

When using nested hostgroups only the last hostgroup in the chain was displayed on the host overview page.
The complete hostgroup name is now shown in the new host table and on the host overview page (details and system properties cards).

Copy link
Contributor

@Thorben-D Thorben-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Parent and child hostgroups are now shown in the card and the table:
image
image
Code looks fine to me too. Test failures are unrelated.

adamruzicka
adamruzicka previously approved these changes Jul 17, 2024
@adamruzicka
Copy link
Contributor

Although, on a related note, the "old" host index page shows the parent hostgroup name in gray and the actual hostgroup name in blue. Would it be possible to replicate this sort of behaviour?
image

@kmalyjur
Copy link
Contributor Author

kmalyjur commented Jul 19, 2024

Although, on a related note, the "old" host index page shows the parent hostgroup name in gray and the actual hostgroup name in blue. Would it be possible to replicate this sort of behaviour?

Good idea, now changed:
image
image

Thank you both for your reviews

@MariaAga MariaAga merged commit 51d8f35 into theforeman:develop Jul 22, 2024
67 checks passed
@MariaAga
Copy link
Member

Thanks everyone!

ouiaId="host-group-link"
component="a"
href={foremanUrl(
`/hosts?search=hostgroup="${hostgroupName}"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one issue with this. If you have a parent host group "parentA" and "parentB" its allowed to have a child host group with the name "child" in both "parentA" and "parentB" - so the child has the same name.
if you know have a button to "child" it will search for "child" having both, hosts of group "parentA/child" AND "parentB/child".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbernhard thank you for noticing, I'm looking into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants