Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37712 - vlan interface detection #10264

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lbayerlein
Copy link

Hi all,

we have missconfigured interface configurations after provisioning EL9 (in our case RHEL 9.4) installations. This happens in %post section.

Foreman Issue on Redmine: https://projects.theforeman.org/issues/37712

If you need further informations, I will send everything you need.

Thanks

@ekohl
Copy link
Member

ekohl commented Aug 5, 2024

In ca34010 @ShimShtein rewrote this I'd expect that to be used. This whole snippet is supposed to be unused and I think keeping it was an omission.

@ShimShtein
Copy link
Member

Indeed we are not using this template anymore. Care to change this PR to remove it?
Take a look at https://github.com/theforeman/foreman/blob/develop/app/views/unattended/provisioning_templates/snippet/kickstart_network_interface.erb template, it should recognize the bond interfaces correctly, and those would be defined last by

@host.interfaces.reject{ |iface| iface.bmc? }.sort_by { |iface| (iface.bond? || iface.bridge?) ? 0 : iface.provision? ? 20 : 10 }.each do |iface|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants