refs #37433 - Revert indentation for subscription_manager_setup #10289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShimShtein @ekohl Since the original change is breaking multiple critical features, I think we should revert it and find a different fix. |
stejskalleos
force-pushed
the
ls/revert_indent
branch
from
e6f6ad6
to
35a554b
Compare
ekohl
approved these changes
Aug 27, 2024
stejskalleos
force-pushed
the
ls/revert_indent
branch
from
35a554b
to
df95582
Compare
stejskalleos
changed the title
|
@ekohl I created a new Redmine ticket since the original one was already released in 3.12. |
ekohl
requested changes
Aug 28, 2024
There was a problem hiding this comment.
@ekohl I created a new Redmine ticket since the original one was already released in 3.12.
3.12 is not GA yet. Please use the original Redmine issue.
This reverts commit aa8f66f. Original commit breaks multiple features: * Provisioning of RHEL 8.y machines (https://issues.redhat.com/browse/SAT-27182) * Templates with heredoc (https://projects.theforeman.org/issues/37741)
stejskalleos
force-pushed
the
ls/revert_indent
branch
from
df95582
to
d241d6c
Compare
Oh yeah, the branching was just a few weeks ago. |
stejskalleos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aa8f66f.
The reverted change is breaking:
subscription_manager_setup