Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37769 - Point Subscription Manager to correct host #10294

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fixes #37769 - Point Subscription Manager to correct host #10294

merged 1 commit into from
Sep 3, 2024

Conversation

ludovicus3
Copy link
Contributor

This fix points the subscription manager to the correct host for rhsm as it may not necessarily be the same as the content source.

@ludovicus3 ludovicus3 changed the title Fixes #37769 Fixes #37769 - Point Subscription Manager to correct host Aug 28, 2024
ekohl
ekohl requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks correct to me, but our checks aren't happy with the commits. Could you rebase them and squash them into one?

ekohl
ekohl approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too the liberty to rebase your PR so that our repository checks should pass.

@ekohl ekohl merged commit 017da5d into theforeman:develop Sep 3, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludovicus3 @ekohl