Basic usage report implementation with reports #10306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 2, 2024
| @@ -56,7 +56,7 @@ class Domain < ApplicationRecord | |||
| prop_group :basic_model_props, ApplicationRecord, meta: { example: 'example.com' } | |||
| property :fullname, String, desc: 'User name for this domain, e.g. "Primary domain for our company"' | |||
| end | |||
| class Jail < Safemode::Jail | |||
| class Jail < Jail | |||
| allow :id, :name, :fullname | |||
There was a problem hiding this comment.
If you're inheriting, I think this is sufficient
Suggested change
| allow :id, :name, :fullname | |
| allow :fullname |
I think I will split this PR into multiple ones that can be merged regardless to this effort. For example this one should be split and applied to all the models, and not just for the two that I have done it for. I think we need to decide which improvements we want as the base implementation, and at least theoretically, we can split the improvements into separate PRs once we want to get that info in the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a base implementation of usage report as a report template.
It shows what changes are required to helpers framework to become suitable for aggregation reports.