Fixes #37789 - Add snapshot tests for global_registration.erb #10315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this is a good start. As you said, it would be nice to add more parameters to test against. However, those parameters come in from the API call, so not sure how to set them in the context of template generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of #9808 @sbernhard and I were talking about adding snapshot tests for the Global Registration template.
As adding sensible and reasonable tests for the Global Registration template with various variables set is not as easy as hoped in the beginning and to not block the original PR unnecessarily, I created this PR for adding snapshot tests for the Global Registration template.