Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37085 - Add netiq as an authentication source #10317

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

knoppi
Copy link

@knoppi knoppi commented Sep 12, 2024

  • Bump version of ldap_fluff to the next version
  • Add netiq to LDAP auth-sources

This PR is a consequence of Bump version to 0.7.0 #80 and Add NetIQ ldap-flavour #71

- Bump version of ldap_fluff to the next version
- Add netiq to LDAP auth-sources

This PR is a consequence of [Bump version to 0.7.0 theforeman#80](theforeman/ldap_fluff#80) and [Add NetIQ ldap-flavour theforeman#71](theforeman/ldap_fluff#71)
@knoppi knoppi requested a review from a team as a code owner September 12, 2024 09:47
@adamruzicka
Copy link
Contributor

Why was the previous PR (#10269) closed?

@knoppi
Copy link
Author

knoppi commented Sep 12, 2024

Why was the previous PR (#10269) closed?

That was some kind of mis-click. Better to continue the old PR?

Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@Thorben-D Thorben-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it would make sense to update the AuthSource welcome page to reflect this change.
On a similar note: Is there a PR to add docs for this?

@sbernhard
Copy link
Contributor

IMO, it would make sense to update the AuthSource welcome page to reflect this change. On a similar note: Is there a PR to add docs for this?

I would not do this. There a hundreds of possible products out there. We should not list every single one.

@sbernhard sbernhard merged commit 5fdab0f into theforeman:develop Sep 25, 2024
52 checks passed
@knoppi
Copy link
Author

knoppi commented Sep 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants