Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37823 - Add Secure Boot and Virtual TPM support for VMware #10324

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixes #37823 - Add Secure Boot and Virtual TPM support for VMware #10324

wants to merge 3 commits into from

Conversation

nofaralfasi
Copy link
Contributor

@nofaralfasi nofaralfasi requested a review from a team as a code owner September 17, 2024 17:34
This was referenced Sep 17, 2024
Closed
Open
@nofaralfasi
Copy link
Contributor Author

While testing this PR, I discovered a pre-existing bug on the compute_attributes form where the Automatic firmware option is not functioning correctly. I’ve created a new issue to track and address this problem: Issue #37834.

@nofaralfasi nofaralfasi mentioned this pull request Sep 18, 2024
Open
@nofaralfasi
Add Firmware option to Libvirt VM creation
33f0560
@nofaralfasi
Fixes #37566 - Add UEFI Secure Boot Firmware to Libvirt
36adaed 
- Added a new firmware type for Secure Boot.
- Enable `enrolled-keys` by default when Secure Boot is activated.
- Added firmware-related methods to the ComputeResource model
  for shared use between VMware and Libvirt.
@nofaralfasi
Fixes #37823 - Add Secure Boot and Virtual TPM support for VMware
f4d3ce0 
- Implement Secure Boot and Virtual TPM functionality for VMware.
- Move default firmware setting from `create_vm` to `parse_args`.
@stejskalleos stejskalleos self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stejskalleos stejskalleos

Labels
Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nofaralfasi @stejskalleos