Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37836 - Add possibility to display action when table is empty #10327

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fixes #37836 - Add possibility to display action when table is empty #10327

merged 1 commit into from
Oct 2, 2024

Conversation

kmalyjur
Copy link
Contributor

image

Needed for this PR.

@github-actions github-actions bot added the UI label Sep 18, 2024
@kmalyjur kmalyjur mentioned this pull request Sep 18, 2024
Merged
Thorben-D
Thorben-D suggested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Thorben-D Thorben-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Do you think it makes sense to extend this feature to TableIndexPage?

@kmalyjur
Copy link
Contributor Author

@Thorben-D Thank you for looking into it. In the end, I won't be using the code, so I don't know if it's okay to merge it anyway for some future use or just leave it. I changed the empty state to this now:
image

Thorben-D
Thorben-D approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Thorben-D Thorben-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your second version looks even better!
Given that you have already gone through the trouble, I would opt to merge the feature, as it is not very invasive and IMO pretty useful for the future.

MariaAga
MariaAga approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmalyjur @Thorben-D!

@MariaAga MariaAga merged commit 13bdb7f into theforeman:develop Oct 2, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thorben-D Thorben-D Thorben-D approved these changes

@MariaAga MariaAga MariaAga approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmalyjur @MariaAga @Thorben-D