Fixes #37877 - Make the config file compatible with 0.2.z and 0.4.z #10340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
ygg-compat
branch
from
d0bbd59
to
e093bce
Compare
pondrejk
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
ack from the functional side, tested together with theforeman/katello-pull-transport-migrate#8
adamruzicka
force-pushed
the
ygg-compat
branch
from
e093bce
to
b1cfc1c
Compare
pondrejk
reviewed
Oct 25, 2024
| if which yggdrasil >/dev/null 2>/dev/null; then | ||
| yggdrasil status | ||
| else | ||
| systemctl status $YGGDRASIL_SERVICE |
There was a problem hiding this comment.
the registration process will stop on this line as the systemctl status will occupy the shell, I think something like systemctl status $YGGDRASIL_SERVICE --no-pager should do it
There was a problem hiding this comment.
Or we could just not do it at all? I'd say it is just eyecandy, we still check if the service is active a couple of lines lower
The service name changed between the package we shipped and official 0.4.z builds, these changes account for this discrepancy. Config file changes: - broker is an array of mqtt servers used by 0.2 - server is an array of mqtt servers used by 0.4 - data-host needs to be set to an empty string to override certain compile-time defaults set in RHEL and CentOS Stream - path-prefix needs to be set to the value we expect to override certain compile-time defaults set in RHEL and CentOS Stream broker and server can be set at both once, each will be honored by their respective versions data-host and path-prefix can be set both at once on our build of yggdrasil they'll just duplicate the defaults, on RHEL/CentOS Stream they'll act as overrides
adamruzicka
force-pushed
the
ygg-compat
branch
from
b1cfc1c
to
ca9f6e4
Compare
ofedoren
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brokeris an array of mqtt servers used by 0.2serveris an array of mqtt servers used by 0.4data-hostneeds to be set to an empty string to override certain compile-time defaults set in RHEL and CentOS Streamprefixneeds to be set to the value we expect to override certain compile-time defaults set in RHEL and CentOS Streambrokerandservercan be set at both once, each will be honored by their respective versionsdata-hostandprefixcan be set both at once on our build of yggdrasil they'll just duplicate the defaults, on RHEL/CentOS Stream they'll act as overridesTODOs: