Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37963 - Make SeedHelper.test_template_requirements public #10361

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

adamruzicka
Copy link
Contributor

To allow using it from plugins seeding their own templates.

To allow using it from plugins seeding their own templates.
def logger
Foreman::Logging.logger('app')
end

def test_template_requirements(template_name, requirements)
requirements.each do |r|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking at this method my mind was rewriting this to .all? to avoid the explicit return statements.

@ekohl
Copy link
Member

ekohl commented Oct 31, 2024

The Katello failure is unrelated:

Failure: test_0636_route api/v2/home/status should have a permission that grants access ActiveRecord::ConnectionTimeoutError: could not obtain a connection from the pool within 5.000 seconds (waited 5.005 seconds); all pooled connections were in use test/test_helper.rb:88:in `before_setup'

We have a workaround for this in the installer, but it's obviously also needed in test (and I've also seen in in dev). The cause is Katello spawning additional threads that eat up the pool.

@ekohl ekohl merged commit e937bee into theforeman:develop Oct 31, 2024
48 of 52 checks passed
@adamruzicka adamruzicka deleted the template-req branch November 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants