Fixes #36872 - Banner for different foreman instances #9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
force-pushed
the
instance-banner
branch
from
2b69d68
to
e8f999a
Compare
MariaAga
changed the title
kmalyjur
reviewed
Nov 16, 2023
| @@ -81,9 +81,14 @@ | |||
| collection: timezones) | |||
| setting('instance_title', | |||
| type: :string, | |||
| description: N_("The instance title is shown on the top navigation bar (requires a page reload)."), | |||
| description: N_("The instance title is shown under the header in a banner (requires a page reload)."), | |||
There was a problem hiding this comment.
Just a detail, but isn't it "above" rather than "under" the header?
Other than that, everything looks great, I also tried multiple banner colors
MariaAga
force-pushed
the
instance-banner
branch
2 times, most recently
from
dcb68b1
to
cb7be65
Compare
kmalyjur
approved these changes
Nov 21, 2023
|
Needs a rebase now |
MariaAga
force-pushed
the
instance-banner
branch
from
cb7be65
to
86347e3
Compare
|
Thanks, rebased, (edited the layout test file) |
ofedoren
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Thanks, @MariaAga. One question though: should we validate color value via settings validator or maybe have somewhere mentioning that invalid values will be ignored and the default (#000000) value will be used instead?
I mean, even if it's obvious, some users might think that the feature doesn't work because of e.g. a simple typo.
MariaAga
force-pushed
the
instance-banner
branch
from
86347e3
to
89b5a1f
Compare
|
@ofedoren Thanks, I rephrased the setting to mention that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example:
settings: