Fixes #37429 - Update theforeman-rubocop to v0.1.2

[archanaserver]

for reference: theforeman/theforeman-rubocop#8 (comment)

Updated this after working on series of cops fixes:

• Fixes #37429 - Update theforeman-rubocop to v0.1.2 #9926
• Fixes #37426 - Rubocop minitest rules fix #9977
• Fixes #37926 - Rubocop layout rules fix #10257
  • Fixes #37425 - Fix Layout/ArgumentAlignment cop #10051
• Fixes #37427 - Fix some Style/ cop #10080
  • Fixes #37424 - Fix Style/RedundantRegexpEscape cop #10063
  • Fixes #37423 - Fix Style/HashEachMethods cop #10064
  • Fixes #37458 - Fix Style/CaseLikeIf cop #10065
  • Refs #37427 - Disable Style/OptionalBooleanParameter cop  #10258
  • Fixes #37432 - Fix Style/GlobalStdStream cop #10067
  • Fixes #37431 - Fix Style/SoleNestedConditional cop #10068
  • Fixes #37420 - Fix Style/AccessorGrouping cop #10071
  • Fixes #37428 - Fix Style/ExplicitBlockArgument cop #10073
  • Fix Style/CommentAnnotation cop #10072

[ekohl]

I would start with fixing up the minitest cops and submit those as a PR. That will trim this down, but also work in develop.

[archanaserver]

@ekohl I was trying to run bundler but throwing this error, I can't continue because I can't understand why it is talking about foreman-admin dir here even though i'm in the right one? Would you mind taking a look here?

[!] There was an error parsing `Gemfile`: There are no gemspecs at /home/akumari/Desktop/foreman-admin. Bundler cannot continue.

 #  from /home/akumari/Desktop/foreman/Gemfile:56
 #  -------------------------------------------
 #  Dir["#{File.dirname(FOREMAN_GEMFILE)}/bundler.d/*.rb"].each do |bundle|
 >    instance_eval(Bundler.read_file(bundle))
 #  end
 #  -------------------------------------------

[ekohl]

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

[archanaserver]

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

Got it, Thanks!

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

[ekohl]

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

In my experience it's best to look at them one by one. RuboCop has --only to do that. Then there are also cops which change a lot of code, like Layout. So I'd first focus on Minitest/*

[stejskalleos]

@archanaserver can you please rebase over the latest develop?

[archanaserver]

@stejskalleos Now this need a long list of RuboCop fix, I have raised PR for Minitest/ and Layout/:

• Fixes #37426 - Rubocop minitest rules fix #9977
• Rubocop layout rules fix #9982

I posted something related to my Layout/ArgumentAlignment cops fixes issue I'm facing, https://community.theforeman.org/t/rubocop-changes-in-foreman-input-needed/36950

[archanaserver]

@ehelms i have rebased PRs, do you mind looking on those PRs? I'm tracking it here #9926 (comment)

[ehelms]

I think this PR is stuck until Katello/katello#11009 (comment) is addressed

[archanaserver]

I think this PR is stuck until Katello/katello#11009 (comment) is addressed

Made some changes there, Katello/katello#11009

[evgeni]

This now looks mergeable?

@ekohl @ehelms what do you think?