Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxmox extention for foreman_bootdisk #90
base: master
Are you sure you want to change the base?
Proxmox extention for foreman_bootdisk #90
Changes from all commits
bc6d98d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would this volume ID not be exactly equal? If the volume IDs are integers I'd imagine this also end up being
123'.include?('12')
soAlso, previously you already used
volid = server.volumes.get("ide2").volid
so why can't you just do:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to destroy the disk 'ide2' as the operation is not possible when vm is powered on. We just want to destroy the volume so that the
iso files
are not piled up in proxmox server.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
volume = storage.volumes.detect { |v| v.volid.include? volid }
returns a different object thanserver.volumes.get("ide2")
. That would surprise me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, server.volumes are disks of the server so it returns the disks,
Fog::Proxmox::Compute::Disks
and storage.volumes are volumes so it returnsFog::Proxmox::Compute::Volumes
. You can remove the volumes without caring about server but you cannot remove the disk without powering off the server (hotplug issue).