Skip to content

Commit

Permalink
Handle comment reviews as a review
Browse files Browse the repository at this point in the history
Many people just leave a comment instead of requesting changes. Today
those are ignored, but it leaves the PR labels in an odd state.

This starts treating comment reviews as being reviewed. It doesn't
request changes on the author because it's unclear who needs to take
action to move things forward.

Link: https://community.theforeman.org/t/reviewing-prprocessors-review-labels/38844
  • Loading branch information
ekohl authored and ehelms committed Aug 2, 2024
1 parent a01156d commit 60ae12d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prprocessor/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ async def on_pr_review_assign_labels(*, pull_request: Mapping, review: Mapping,
labels.discard(Label.NOT_YET_REVIEWED)
labels.discard(Label.NEEDS_RE_REVIEW)
labels.add(Label.WAITING_ON_CONTRIBUTOR)
elif state == 'approved':
elif state in ('approved', 'commented'):
labels.discard(Label.NOT_YET_REVIEWED)
labels.discard(Label.NEEDS_RE_REVIEW)

Expand Down

0 comments on commit 60ae12d

Please sign in to comment.