Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivial r10k integration point. #853

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jan 10, 2023

Installation and configuration of r10k is out of scope. This merely provides a simple way to use it with the git repo workflow.

In my experience r10k also tends to use the isolated environment types from https://www.puppet.com/docs/puppet/7/environment_isolation.html

templates/server/post-receive.erb Outdated Show resolved Hide resolved
templates/server/post-receive.erb Outdated Show resolved Hide resolved
templates/server/post-receive.erb Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Jan 11, 2023

FYI: I first want to get #841 merged to get CI green again and then I'll ask you to rebase this and your other PRs.

@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 11, 2023

Sounds good, I'll try to keep an eye out, but if I miss it let me know and I'll get rebasing :)

@ekohl
Copy link
Member

ekohl commented Jan 11, 2023

In case you missed it, it was merged.

Installation and configuration of `r10k` is out of scope.
This merely provides a simple way to use it with the git repo workflow.
@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 11, 2023

:) Rebased my various PRs

@ekohl
Copy link
Member

ekohl commented Jan 13, 2023

Something I've been thinking about: r10k (and g10k for that matter) can both update environments based on a git repo. Instead of running r10k for every environment that was updated, would it make sense to instead look at an entirely different hook script that just runs r10k as post-receive?

The one consideration may be that r10k may not be able to do git submodules, though that may be acceptable for many users.

@jcpunk
Copy link
Contributor Author

jcpunk commented Jan 13, 2023

My understanding is the r10k native git integration requires a bunch more config stuff. That could be an interesting point of integration, but is probably a bit of work...

The branch mapping feature is also something handy I'm not sure is in r10k directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants