Use GitHub Actions for CI #96
Conversation
mocha and smart_proxy are already specified in Gemfile and others aren't used at all.
|
Looks like Ruby 3.0 does some globbing that others don't. Mocking is such an awful tool. |
|
This time Ruby 3.1 failed. I suppose it's sort of random and suggests the test suite is already unreliable. The bigger matrix just uncovers it. |
| @@ -3,8 +3,7 @@ source 'https://rubygems.org' | |||
| gemspec | |||
|
|
|||
| group :development do | |||
| gem 'smart_proxy', git: 'https://github.com/theforeman/smart-proxy', | |||
| branch: 'develop' | |||
| gem 'smart_proxy', github: 'theforeman/smart-proxy', branch: ENV['SMART_PROXY_BRANCH'] | |||
There was a problem hiding this comment.
In theforeman/smart_proxy_plugin_template@71bd2b6 we used ENV.fetch(…, 'develop') -- or will branch default to the default branch if it's nil?
There was a problem hiding this comment.
I tested it on Fedora without specifying it and that works. The Bundler docs haven't been updated, but looks like this is a Rubygem 2.3 feature: rubygems/rubygems@6e032a9
Would you prefer to support < 2.3?
There was a problem hiding this comment.
I have no idea what < 2.3 means for rubygems 🙈
But also, we should be consistent between here and the docs in the actions repo and the template ;)
This makes a change to always use glob_path in the runtime code so it can be easily stubbed in tests. Stubbing Dir.glob creates problems if other code also runs it. It also makes the tests more explicit by providing a correct path and asserting the resulting parsed result is correct. Previously it only returned filenames, which isn't how Dir.glob works.
This allows us to remove a workflow in Jenkins.