fix: org-selecion -> org-selection route typo causing blank page post-login - #53
Merged
Merged
Conversation
proxy.ts redirects users who are signed in but have no organization yet to /org-selection - but the actual page folder was spelled org-selecion (missing the second 't'). The redirect target and the real route never matched, so any newly-signed-in user without an org would land on a URL with no corresponding page - blank/broken page right after a fully successful sign-in, including 2FA. This was likely never caught before because most testing focused on Clerk/Convex auth completing successfully, not what happens immediately after for a user who doesn't have an org assigned yet. Verified: apps/web typecheck and build clean, route now correctly shows as /org-selection/[[...org-selection]].
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
After a fully successful sign-in (including 2FA), new users with no organization yet saw a blank page instead of the org selection screen.
Root cause
`proxy.ts` redirects signed-in users without an org to `/org-selection`, but the actual page folder was spelled `org-selecion` (missing the second "t"). The redirect target never matched any real route, so it landed on a URL with no corresponding page.
This likely went uncaught because most testing focused on getting Clerk/Convex auth to complete successfully, not on what happens immediately after for a brand-new user with no org assigned yet.
Fix
Renamed the folder to match the correct spelling (which the dynamic segment `[[...org-selection]]` already used correctly, just the parent folder had the typo).
Verified: typecheck and build clean, route now correctly resolves as `/org-selection/[[...org-selection]]`.