revert: read Clerk issuer domain from env var, not hardcoded - #54
Merged
Conversation
A hardcoded https://clerk.solvia-web.fremn.com landed via a direct push to main. It happened to resolve to the exact same value already confirmed correct in Convex's CLERK_JWT_ISSUER_DOMAIN, so functionally this is a no-op - but hardcoding means anyone changing the Clerk domain in the future has to remember to also update this file, not just the Convex dashboard. Back to Convex's own documented pattern.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hardcoded `https://clerk.solvia-web.fremn.com\` landed via a direct push to `main` (bypassing PR review, possible since branch protection currently allows admins to push directly). It happened to resolve to the exact same value already confirmed correct in Convex's `CLERK_JWT_ISSUER_DOMAIN`, so this is functionally a no-op - but hardcoding it means anyone changing the Clerk domain in the future has to remember to update this file too, not just the Convex dashboard.
Reverts to Convex's own documented pattern (`process.env.CLERK_JWT_ISSUER_DOMAIN!`).