chore(improvement): Implement makim and containers-sugar #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmnlab
requested changes
Mar 31, 2023
xmnlab
reviewed
Apr 3, 2023
xmnlab
reviewed
Apr 11, 2023
| @@ -14,7 +14,7 @@ env: | |||
| _AIRFLOW_WWW_USER_LAST_NAME: Admin | |||
| _AIRFLOW_WWW_USER_PASSWORD: airflow | |||
| _AIRFLOW_WWW_USER_USERNAME: airflow | |||
| AIRFLOW_FILES_PATH_DIR_HOST: /home/runner/work/EpiGraphHub/EpiGraphHub/docker/airflow | |||
| AIRFLOW_FILES_PATH_DIR_HOST: /home/runner/work/EpiGraphHub/containers/airflow | |||
There was a problem hiding this comment.
are you sure that it is correct? I would say that it would be
Suggested change
| AIRFLOW_FILES_PATH_DIR_HOST: /home/runner/work/EpiGraphHub/containers/airflow | |
| AIRFLOW_FILES_PATH_DIR_HOST: /home/runner/work/EpiGraphHub/EpiGraphHub/containers/airflow |
|
we have a block here. we need a easy way to install the new docker-compose (golang) with poetry ... |
|
@YurelyCamacho could you rebase this branch please on top of upstream/main? |
|
according to the current state of makim and containers-sugar, and compose-go, it should be easy now to have this PR ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra deps to the project. Makim and containers-sugar are tools designed to avoid creating boilerplates across repositories and to simplify the management of the Docker stack.
By @Anavelyz and @YurelyCamacho
@xmnlab