Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequential alignment example #98

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sequential alignment example #98

wants to merge 3 commits into from

Conversation

ArinaDanilina
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ArinaDanilina ArinaDanilina requested a review from MUCDK February 5, 2025 23:10
@@ -0,0 +1,469 @@
{
Copy link
Collaborator

@MUCDK MUCDK Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add that we focus on the differences of policies in the AlignmentProblem. Please also include StarPolicy.


Reply via ReviewNB

@@ -0,0 +1,469 @@
{
Copy link
Collaborator

@MUCDK MUCDK Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo consits


Reply via ReviewNB

@@ -0,0 +1,469 @@
{
Copy link
Collaborator

@MUCDK MUCDK Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this, talk about the policies, i.e. say which options there are (StarPolicy, SeqeuentialPolicy), similarly to what we had in the issue.


Reply via ReviewNB

@ArinaDanilina ArinaDanilina requested a review from MUCDK March 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants