Feature/issue 27 function to store artifact #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…o feature/issue-27-function-to-store-artifact
…/github.com/theislab/spatialdata-db into feature/issue-27-function-to-store-artifact
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Zethson
reviewed
Feb 18, 2025
| import lamindb as ln | ||
|
|
||
|
|
||
| def store_dataset( |
There was a problem hiding this comment.
Aren't we using Google docstring style?
| """ | ||
| Store a cached artifact in a specified directory, rename it if needed. | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
No types and defaults in docstrings, please. They're all in the function signature.
| import lamindb.setup as ln_setup | ||
|
|
||
|
|
||
| def pytest_sessionstart(session): |
There was a problem hiding this comment.
The yield version that I send you already does the setup and cleanup so you don't need to divide it into two functions. But nbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue https://github.com/theislab/spatialdata-db-pm/issues/27
Adds a function that stores a cached dataset locally.
Known Issue/Missing Feature