-
-
Notifications
You must be signed in to change notification settings - Fork 451
fix: carousel init bug #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: carousel init bug #1295
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 99.54% 95.53% -4.02%
==========================================
Files 163 217 +54
Lines 6621 9666 +3045
Branches 401 558 +157
==========================================
+ Hits 6591 9234 +2643
- Misses 30 432 +402 ☔ View full report in Codecov by Sentry. |
db828b7
to
06c9af2
Compare
@coderabbitai review |
WalkthroughThis update introduces a straightforward yet effective change to the Carousel component, specifically by adding an inline style to enable horizontal scrolling ( Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/components/Carousel/Carousel.tsx (1 hunks)
Additional comments: 1
src/components/Carousel/Carousel.tsx (1)
- 154-154: The addition of
style={{ overflowX: 'scroll' }}
to theScrollContainer
is a straightforward approach to address the carousel's initialization issue. This change should ensure that the carousel is scrollable horizontally from the initial page load, which is crucial for the correct display and functionality of the carousel items.However, it's important to consider the impact of this change on accessibility and performance. Specifically, ensure that this does not hinder keyboard navigation or screen reader usage. Additionally, if there are concerns about performance implications due to forcing scroll behavior, it might be worth exploring alternative solutions.
@abdulbasithqb please, don't use merge to sync with main, instead use rebase. Revert the merge and rebase, otherwise it won't be possible to accept the PR. |
This reverts commit 3c86b44.
closed this PR and raised a new one PR: #1305 |
fix: carousel init bug
Changes:
Added Overflow Props to ScrollContainer
Why:
fixes: #1283
Screen-record:
Screen.Recording.2024-03-11.at.4.01.15.PM.mov
Summary by CodeRabbit