Fix drawer backdrop classes#967
Open
MaximilianKos wants to merge 2 commits intothemesberg:mainfrom
Open
Conversation
|
Would be awesome if this is merged. |
|
I hit the same problem with Modal, and presume the fix is the same. |
Just found this PR for Modal #1001 |
|
Same issue! |
Author
|
Hi @zoltanszogyenyi. Can this be considered for merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across the problem that i couldnt add custom backdrop classes to my drawer.
I found out that the logic is not implemented in the code, which gets the users data attribute to set the custom classes.
This pull request adds the necessary logic to retrieve the data attribute and pass it to the Drawer. If no data attribute is found, it defaults to the
Default.backdropClassesconfiguration.This fix is related to #913.