Fix ComboBox drawing over cursor (in mt_ui 1) - #664
Open
TheLostInPlace wants to merge 1 commit into
Open
Conversation
…rsor With mt_ui 1 the ui update runs on the game thread while seqRender processes on the main thread, so the per frame remove and add landed mid iteration and the open list painted after the cursor. Registering once in the constructor keeps the slot in sorted order and the render callback now draws the list only while the box and every parent are shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
mt_ui 1the ui update runs on the game thread whileseqRenderprocesses on the main thread, so the per frame remove and add landed mid iteration and the open list painted after the cursor.Registering once in the constructor keeps the slot in sorted order and the render callback now draws the list only while the box and every parent are shown.