Skip to content

feat: Change default scope seperator to comply with OAuth RFC. #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Change default scope seperator to comply with OAuth RFC. #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7c5029
changed default scope separator
Kudze Nov 20, 2025
03cd1c0
patch testScopesOverloadedDuringAuthorize test case
Kudze Nov 20, 2025
cd9813e
patch testGetAccessTokenWithScope test case
Kudze Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Provider/AbstractProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,11 +386,11 @@ abstract protected function getDefaultScopes();
* Returns the string that should be used to separate scopes when building
* the URL for requesting an access token.
*
* @return string Scope separator, defaults to ','
* @return string Scope separator, defaults to ' '
*/
protected function getScopeSeparator()
{
return ',';
return ' ';
}

/**
Expand Down
4 changes: 2 additions & 2 deletions test/src/Provider/AbstractProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public function testScopesOverloadedDuringAuthorize()
parse_str(parse_url($url, PHP_URL_QUERY), $qs);

$this->assertArrayHasKey('scope', $qs);
$this->assertSame('foo,bar', $qs['scope']);
$this->assertSame('foo bar', $qs['scope']);
}

public function testAuthorizationStateIsRandom()
Expand Down Expand Up @@ -697,7 +697,7 @@ public function testGetAccessTokenWithScope($method)
->once()
->with(
['client_id' => 'mock_client_id', 'client_secret' => 'mock_secret', 'redirect_uri' => 'none'],
['code' => 'mock_authorization_code', 'scope' => 'foo,bar']
['code' => 'mock_authorization_code', 'scope' => 'foo bar']
)
->andReturn([]);

Expand Down