Skip to content

ASoC: core: Change device numbering #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amadeuszslawinski-intel wants to merge 1 commit into from
Closed

ASoC: core: Change device numbering #5311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sound/soc/soc-core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,8 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
*/
rtd->card = card;
rtd->dai_link = dai_link;
rtd->id = card->num_rtd++;
if (!rtd->dai_link->no_pcm)
rtd->id = card->num_rtd++;
Copy link
Copy Markdown
Collaborator

@ujfalusi ujfalusi Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the patch which needs to be fixed is
8b12da9 ("ASoC: cleanup function parameter for rtd and its id")

before this patch the rtd->dai_link->id was passed as PCM index to soc_new_pcm(), but after it the rtd->id is used and this can be the route of the problem?

rtd->pmdown_time = pmdown_time; /* default power off timeout */

/* see for_each_card_rtds */
Expand Down