fixup! ASoC: soc_sdw_utils: skip the endpoint that doesn't present#5368
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom Mar 27, 2025
Merged
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood and
plbossart
as code owners
ujfalusi
reviewed
Mar 20, 2025
sound/soc/sdw_utils/soc_sdw_utils.c
Outdated
| if (dai_info->quirk && | ||
| !(dai_info->quirk_exclude ^ !!(dai_info->quirk & ctx->mc_quirk))) | ||
| continue; | ||
|
|
bardliao
force-pushed
the
fixup-skip-endpoint
branch
3 times, most recently
from
4b80a6c to
1bfc649
Compare
ujfalusi
previously approved these changes
Mar 21, 2025
ranj063
reviewed
Mar 25, 2025
The existing solution test the dai_info->quirk first and skip the endpoints that is not present according to the quirk. However, if the mc_quirk is not set and dai_info->quirk_exclude is set, then the endpoint will be skip. But we will only set the mc_quirk when the BIOS doesn't provide the right information. We don't want to skip the endpoint just because the mc_quirk is not set. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
fixup-skip-endpoint
branch
from
1bfc649 to
9d16c9e
Compare
Collaborator
Author
ujfalusi
approved these changes
Mar 26, 2025
ranj063
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing solution test the dai_info->quirk first and skip the endpoints that is not present according to the quirk. However, if the mc_quirk is not set and dai_info->quirk_exclude is set, then the endpoint will be skip. But we will only set the mc_quirk when the BIOS doesn't provide the right information. We don't want to skip the endpoint just because the mc_quirk is not set.