ACP stack improvements and add SoundWire IO support for ACP7.0 & ACP7.1 platforms#5392
ACP stack improvements and add SoundWire IO support for ACP7.0 & ACP7.1 platforms#5392vijendarmukunda wants to merge 9 commits intothesofproject:topic/sof-devfrom
Conversation
|
@bardliao @ranj063 @plbossart Could you please help to review the patches? |
ranj063
left a comment
ranj063
left a comment
There was a problem hiding this comment.
looks good except for a couple of nits @vijendarmukunda
Else condition is not required after break/return statement. Remove else condition in resume callback. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Add missing acp descriptor field acp_error_stat for ACP7.0 platform. Fixes: 490be7b ("ASoC: SOF: amd: add support for acp7.0 based platform") Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Add SOF support for ACP7.1 platform. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Update SoundWire specific acp descriptor structure fields for ACP7.0 & ACP7.1 platforms. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
As per design flow for ACP7.0 & ACP7.1 platforms, enable ACP_PME_EN register for below scenarios. 1. During acp init sequence 2. During resume sequence for SoundWire ClockStop power mode. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Below mentioned register sequence should be part of acp init sequence. 1) Set ACP clock mux selection register to ACP_ACLK clock source. 2) Enable ACP global interrupt enable register 3) Enable ACP error interrupt mask. ACP reset sequence should contain code related to asserting acp soft reset and release the soft reset. Move the rest of the registers programming to acp init sequence. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Enable SoundWire host wake interrupt mask during acp init sequence based on wake enable checks for each SoundWire manager instance for ACP7.0 & ACP7.1 platforms. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Add SoundWire wake interrupt handling for ACP7.0 & ACP7.1 platforms. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Add build support for SoundWire for ACP7.0/ACP7.1 platforms. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
a1500e5 to
197029f
Compare
|
@ranj063 : If you don't have further review comments, Could you please approve the PR? |
done @vijendarmukunda. Will you take care of sending it upstream? |
@ranj063 Once this PR gets merged. I will send the patch series to mailing list. Does anything got changed in the work flow? |
@bardliao how do you want to handle this? |
@bardliao : Once the PR gets merged, If patches upstream taken care automatically. Then its fine. I won't send patch series to mailing list explicitly. |
|
@vijendarmukunda Please post them to the mailing list with our Reviewed-by tag. I will close the PR and get the commits from ASoC tree. |
Is it new process? is it applicable to all the Pull requests on SOF Linux? |
@vijendarmukunda
Good point. We are willing to submit all SOF patches. The point is that if it is merged to our repo, please let us submit the series. Otherwise, it may cause conflict when we do upstream merge. What do you think? Do you want us to merge this PR and submit the series to ASoC? |
It make sense. we can decide based on case to case. Thanks We will push the patches to mailing list. |
Ok, then I will close the PR. :) |
3 participants
This patch series contains