Skip to content

soundwire: only compute port params in specific stream states #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bardliao merged 1 commit into from
May 8, 2025
Merged

soundwire: only compute port params in specific stream states #5393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions drivers/soundwire/generic_bandwidth_allocation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ static void _sdw_compute_port_params(struct sdw_bus *bus,
port_bo = 1;

list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) {
/*
* Only runtimes with CONFIGURED, PREPARED, ENABLED, and DISABLED
* states should be included in the bandwidth calculation.
*/
if (m_rt->stream->state > SDW_STREAM_DISABLED ||
m_rt->stream->state < SDW_STREAM_CONFIGURED)
continue;
Copy link
Copy Markdown
Collaborator

@ujfalusi ujfalusi May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message: s/we should not take in count/we should not take into account/
?

Copy link
Copy Markdown
Collaborator Author

@bardliao bardliao May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message: s/we should not take in count/we should not take into account/ ?

fixed

sdw_compute_master_ports(m_rt, &params[i], &port_bo, hstop);
}

Expand Down
Loading