Skip to content

ASoC: SOF: Intel: hda: Fix UAF when reloading module #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bardliao wants to merge 1 commit into from
Closed

ASoC: SOF: Intel: hda: Fix UAF when reloading module #5407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sound/soc/sof/intel/hda.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@ static void hda_generic_machine_select(struct snd_sof_dev *sdev,
if (!tplg_filename)
return;

hda_mach->sof_tplg_filename = tplg_filename;
pdata->tplg_filename = tplg_filename;
}
Comment on lines +1080 to 1081
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change correctly stores the topology filename in pdata, avoiding the previous use-after-free issue when the global variable was freed during module unload.

Suggested change
pdata->tplg_filename = tplg_filename;
}
pdata->tplg_filename = kstrdup(tplg_filename, GFP_KERNEL);
if (!pdata->tplg_filename) {
dev_err(sdev->dev, "Failed to allocate memory for tplg_filename\n");
return;
}

Copilot uses AI. Check for mistakes.

if (codec_num == 2 ||
Expand Down
Loading