ALSA/ASoC/SOF: Initial NVL-S (Nova Lake) support by ujfalusi · Pull Request #5508 · thesofproject/linux

ujfalusi · 2025-08-12T06:20:42Z

Hi,

this series adds initial support for NVL-S from the Nova Lake family.
NVL-S includes ACE4 audio subsystem, it has 2 DSP cores.

lyakh · 2025-08-12T06:31:30Z

sound/soc/sof/intel/nvl.c

+
+int sof_nvl_set_ops(struct snd_sof_dev *sdev, struct snd_sof_dsp_ops *dsp_ops)
+{
+	return sof_ptl_set_ops(sdev, dsp_ops);


in similar platform-inheritance cases (even across ACE major versions) - would it make sense to add a comment, stating that inheritance explicitly?

ujfalusi · 2025-08-12T08:21:11Z

Changes since v1:

add comment that we are re-using PTL ops (requested by @lyakh )
correct firmware binary name to sof-nvl-s

bardliao · 2025-08-13T00:43:05Z

sound/soc/intel/common/soc-acpi-intel-nvl-match.c

@@ -0,0 +1,41 @@
+// SPDX-License-Identifier: GPL-2.0-only


Commit message says headset codec support but the commit only adds mockup devices.

OK, I'll drop the headset part from the message.

bardliao · 2025-08-13T00:45:03Z

sound/soc/sof/intel/pci-nvl.c

+	.default_fw_filename = {
+		[SOF_IPC_TYPE_4] = "sof-nvl-s.ri",
+	},
+	.nocodec_tplg_filename = "sof-nvl-nocodec.tplg",


Will NVL use the same nocodec topology as NVL-S?

Yes, historically we did this on all platforms tgl/tgl-h is using sof-tgl-nocodec, arl/arl-s is using sof-arl-nocodec, adl/adl-s/adl-n is using sof-adl-nocodec.

I think these nocodec topologies could be present per DSP architecture:
sof-cavs25-nocodec for tgl/adl/rpl
sof-ace1-nocodec for mtl/arl
...

I would leave it like this.

ujfalusi · 2025-08-13T07:29:27Z

Changes since v2:

drop mention of headset from the initial mach table patch
correct year in new files to 2025

kv2019i

One minors nit, please check.

sound/soc/sof/intel/Kconfig

kv2019i · 2025-08-13T10:44:06Z

sound/soc/sof/intel/nvl.c

+// Copyright(c) 2025 Intel Corporation
+
+/*
+ * Hardware interface for audio DSP on PantherLake.


For Nova Lake.

good catch!

On the other hand other files (again) have the name written w/o the space.

still says PantherLake

ujfalusi · 2025-08-13T12:06:23Z

Changes since v3:

fix file comment for Nova Lake (from PantherLake)

ujfalusi · 2025-08-26T12:16:47Z

Changes since v4:

add missed sdw_process_wakeen callback for NVL-S

ranj063 · 2025-09-11T20:29:03Z

sound/soc/sof/intel/pci-nvl.c

+MODULE_DESCRIPTION("SOF support for NovaLake platforms");
+MODULE_IMPORT_NS("SND_SOC_SOF_INTEL_HDA_GENERIC");
+MODULE_IMPORT_NS("SND_SOC_SOF_INTEL_HDA_COMMON");
+MODULE_IMPORT_NS("SND_SOC_SOF_INTEL_PTL");


is this needed here? It already done in nvl.c?

ranj063 · 2025-09-11T20:29:34Z

@ujfalusi just a couple of minor comments. Should be good to go after those are addressed

Add Nova Lake S (NVL-S) audio Device ID Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Add HDMI codec ID for Intel Nova Lake platform. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

For now the tables are basic for mockup devices Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Add rt722 on SDW link 3 support Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Add support for Nova Lake S (NVL-S). Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Same recipes as PTL for NVL-S from the Nova Lake family. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Add NVL-S to the PCI-ID list. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ujfalusi · 2025-09-16T07:02:30Z

Changes since v5:

Finally managed to replace PantherLake with NovaLake in nvl.c comment
Drop one MODULE_IMPORT_NS()

ujfalusi requested review from bardliao, dbaluta, kv2019i, lgirdwood, lyakh, plbossart and ranj063 as code owners August 12, 2025 06:20

lyakh reviewed Aug 12, 2025

View reviewed changes

ujfalusi force-pushed the peter/sof/pr/initial-nvl-s-01 branch from 5bd6023 to 83d5a1f Compare August 12, 2025 08:20

bardliao reviewed Aug 13, 2025

View reviewed changes

ujfalusi force-pushed the peter/sof/pr/initial-nvl-s-01 branch from 83d5a1f to a05f309 Compare August 13, 2025 07:28

bardliao previously approved these changes Aug 13, 2025

View reviewed changes

kv2019i reviewed Aug 13, 2025

View reviewed changes

ujfalusi dismissed bardliao’s stale review via dac7760 August 13, 2025 12:05

ujfalusi force-pushed the peter/sof/pr/initial-nvl-s-01 branch from a05f309 to dac7760 Compare August 13, 2025 12:05

bardliao previously approved these changes Aug 14, 2025

View reviewed changes

kv2019i previously approved these changes Aug 14, 2025

View reviewed changes

ujfalusi dismissed stale reviews from kv2019i and bardliao via bd1a360 August 26, 2025 12:16

ujfalusi force-pushed the peter/sof/pr/initial-nvl-s-01 branch from dac7760 to bd1a360 Compare August 26, 2025 12:16

kv2019i previously approved these changes Aug 26, 2025

View reviewed changes

bardliao previously approved these changes Sep 1, 2025

View reviewed changes

bardliao mentioned this pull request Sep 8, 2025

ASoC: SOF: Intel: add -bt tplg suffix if BT is present #5518

Merged

ranj063 reviewed Sep 11, 2025

View reviewed changes

ujfalusi dismissed stale reviews from bardliao and kv2019i via cf72c99 September 16, 2025 07:01

ujfalusi force-pushed the peter/sof/pr/initial-nvl-s-01 branch from bd1a360 to cf72c99 Compare September 16, 2025 07:01

ujfalusi and others added 7 commits September 16, 2025 10:02

PCI: pci_ids: Add Intel Nova Lake S audio Device ID

402a30d

Add Nova Lake S (NVL-S) audio Device ID Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ALSA: hda/hdmi: intelhdmi: add HDMI codec ID for Intel NVL

b08583a

Add HDMI codec ID for Intel Nova Lake platform. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ASoC: Intel: soc-acpi: add NVL match tables

b1d7610

For now the tables are basic for mockup devices Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ASoC: Intel: soc-acpi-intel-nvl-match: add rt722 l3 support

b7469bd

Add rt722 on SDW link 3 support Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>

ASoC: SOF: Intel: add initial support for NVL-S

f4fb173

Add support for Nova Lake S (NVL-S). Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ALSA: hda: core: intel-dsp-config: Add support for NVL-S

b878d2a

Same recipes as PTL for NVL-S from the Nova Lake family. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ALSA: hda: controllers: intel: add support for Nova Lake S

cf72c99

Add NVL-S to the PCI-ID list. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

kv2019i approved these changes Sep 16, 2025

View reviewed changes

ranj063 approved these changes Sep 16, 2025

View reviewed changes

bardliao merged commit 6d51063 into thesofproject:topic/sof-dev Sep 22, 2025
9 of 16 checks passed

Conversation

ujfalusi commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 13, 2025

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 13, 2025

Uh oh!

ujfalusi commented Aug 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranj063 commented Sep 11, 2025

Uh oh!

ujfalusi commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants