Skip to content

Comments

ASoC: Intel: soc-acpi-intel-ptl-match: drop rt721 related match tables#5658

Merged
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
macchian:dev-sdw-match-table
Jan 30, 2026
Merged

ASoC: Intel: soc-acpi-intel-ptl-match: drop rt721 related match tables#5658
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
macchian:dev-sdw-match-table

Conversation

@macchian
Copy link

@macchian macchian commented Jan 28, 2026

Use functional topologies to support all RT721-related topology and
amplifier combinations, e.g. sof-ptl-rt721.tplg, sof-ptl-rt721-l3-rt1320-l3.tplg.
If these entries are not removed, they will all use the sof-ptl-rt721.tplg.

@bardliao
Copy link
Collaborator

@macchian Please remove all rt721 and rt722 match tables and mentation that otherwise all audio configurations with rt721 or rt722 will use the sof-ptl-rt721/rt722.tplg.

@macchian macchian force-pushed the dev-sdw-match-table branch from de36e63 to bcae4a4 Compare January 29, 2026 06:06
@macchian
Copy link
Author

macchian commented Jan 29, 2026

@macchian Please remove all rt721 and rt722 match tables and mentation that otherwise all audio configurations with rt721 or rt722 will use the sof-ptl-rt721/rt722.tplg.

I removed all RT721 topology match tables in this PR currently. Could we merge this first?
To be removed the remaining SoundWire codecs once all SKUS are verified.

@macchian macchian changed the title ASoC: Intel: soc-acpi-intel-ptl-match: drop rt721_l3 match table ASoC: Intel: soc-acpi-intel-ptl-match: drop rt721 related match tables Jan 29, 2026
Use functional topologies to support all RT721-related topology and
amplifier combinations,
e.g. sof-ptl-rt721.tplg, sof-ptl-rt721-l3-rt1320-l3.tplg.

If these entries are not removed, they will all use the sof-ptl-rt721.tplg.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@macchian macchian force-pushed the dev-sdw-match-table branch from bcae4a4 to 3dae1cf Compare January 30, 2026 02:42
@macchian
Copy link
Author

@macchian Please remove all rt721 and rt722 match tables and mentation that otherwise all audio configurations with rt721 or rt722 will use the sof-ptl-rt721/rt722.tplg.

Added in commit messages. Done.

@bardliao bardliao merged commit 86b5062 into thesofproject:topic/sof-dev Jan 30, 2026
9 of 16 checks passed
vineethrp pushed a commit to vineethrp/pKVM-IA that referenced this pull request Feb 2, 2026
…tch tables

Use functional topologies to support all RT721-related topology and
amplifier combinations,
e.g. sof-ptl-rt721.tplg, sof-ptl-rt721-l3-rt1320-l3.tplg.

If these entries are not removed, they will all use the sof-ptl-rt721.tplg.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>

Bug: 475386887
Test: cat /proc/asound/cards, check sound carsd is listed.

link: thesofproject/linux#5658

Change-Id: I4636e8bb74a34a59e4b6b436a65461b239c794a9
Signed-off-by: Mac Chiang <mac.chiang@intel.corp-partner.google.com>
Signed-off-by: Norman Bintang <normanbt@google.com>
@naveen-manohar
Copy link

@bardliao @macchian now i noticed with this PR#5658 RT721-SDW AIC at l3 fails to bind sound card on both PTL & WCL
Seems func topology, dint pick properly for RT721

[   12.836764] sof_sdw sof_sdw: Failed to open topology file: _intel/sof-ipc4-tplg/sof-sdca-jack-id0.tplg_, you might need to
[   12.836765] sof_sdw sof_sdw: download it from https://github.com/thesofproject/sof-bin/
[   12.836767] sof-audio-pci-intel-ptl 0000:00:1f.3: Function topology is required, please upgrade sof-firmware
[   12.836768] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22
[   12.836769] sof-audio-pci-intel-ptl 0000:00:1f.3: ASoC error (-22): at snd_soc_component_probe() on 0000:00:1f.3
[   12.836777] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[   12.836847] sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[   12.836853] sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

cc: @udaymb

@davidlin923
Copy link

n now i noticed with this PR#5658 RT721-SDW AIC at l3 fails to bind sound card on both PTL & WCL
Seems func topology, dint pick properly for RT721

I remember function topology is to simplify match table, especially on different combinations, so we will not need to create new monolithic topology for new devices.

You can download from the latest sof-bin about function topology(sdca keyword).

sof-ipc4-tplg-v2.14
-sof-sdca-1amp-id2.tplg
-sof-sdca-2amp-id2.tplg
-sof-sdca-jack-id0.tplg
-sof-sdca-mic-id4.tplg

sof-ipc4-tplg-v2.14.3
-sof-sdca-3amp-id2.tplg
-sof-sdca-4amp-id2.tplg

@ujfalusi
Copy link
Collaborator

@bardliao @macchian now i noticed with this PR#5658 RT721-SDW AIC at l3 fails to bind sound card on both PTL & WCL Seems func topology, dint pick properly for RT721

[   12.836764] sof_sdw sof_sdw: Failed to open topology file: _intel/sof-ipc4-tplg/sof-sdca-jack-id0.tplg_, you might need to
[   12.836765] sof_sdw sof_sdw: download it from https://github.com/thesofproject/sof-bin/
[   12.836767] sof-audio-pci-intel-ptl 0000:00:1f.3: Function topology is required, please upgrade sof-firmware
[   12.836768] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22
[   12.836769] sof-audio-pci-intel-ptl 0000:00:1f.3: ASoC error (-22): at snd_soc_component_probe() on 0000:00:1f.3
[   12.836777] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[   12.836847] sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[   12.836853] sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

why are there underscores around the topology filename in the print?
_intel/sof-ipc4-tplg/sof-sdca-jack-id0.tplg_

@davidlin923
Copy link

@bardliao @macchian now i noticed with this PR#5658 RT721-SDW AIC at l3 fails to bind sound card on both PTL & WCL Seems func topology, dint pick properly for RT721

[   12.836764] sof_sdw sof_sdw: Failed to open topology file: _intel/sof-ipc4-tplg/sof-sdca-jack-id0.tplg_, you might need to
[   12.836765] sof_sdw sof_sdw: download it from https://github.com/thesofproject/sof-bin/
[   12.836767] sof-audio-pci-intel-ptl 0000:00:1f.3: Function topology is required, please upgrade sof-firmware
[   12.836768] sof-audio-pci-intel-ptl 0000:00:1f.3: error: failed to load DSP topology -22
[   12.836769] sof-audio-pci-intel-ptl 0000:00:1f.3: ASoC error (-22): at snd_soc_component_probe() on 0000:00:1f.3
[   12.836777] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[   12.836847] sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[   12.836853] sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

why are there underscores around the topology filename in the print? _intel/sof-ipc4-tplg/sof-sdca-jack-id0.tplg_

From the same discussion in google chat, the log is no "_". So it should be pasting error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants