test: add test jack detection if DSP is suspended#1321
Merged
redzynix merged 1 commit intothesofproject:mainfrom Nov 27, 2025
Merged
test: add test jack detection if DSP is suspended#1321redzynix merged 1 commit intothesofproject:mainfrom
redzynix merged 1 commit intothesofproject:mainfrom
Conversation
arikgreen
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
arikgreen
force-pushed
the
awilczax/add-test-jack-detection-d3
branch
from
50eabd5 to
e548c1d
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new test case to verify jack detection functionality when the DSP is in D3 suspended state. The test uses a USB relay to simulate physical jack plug/unplug events and validates that both jack detection status and DSP power state changes are handled correctly.
- Implements automated jack detection testing using USB relay hardware
- Validates DSP state transitions during jack events while suspended
- Includes comprehensive error handling and configuration options
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marc-hb
reviewed
Oct 31, 2025
|
|
||
| # shellcheck disable=SC1091 source=case-lib/lib.sh | ||
| source "${TESTLIB}/lib.sh" | ||
| # shellcheck disable=SC1091 source=case-lib/relay.sh |
Collaborator
There was a problem hiding this comment.
Suggested change
| # shellcheck disable=SC1091 source=case-lib/relay.sh | |
| # shellcheck source=case-lib/relay.sh |
When someone runs shellcheck outside the top directory, you do want shellcheck to warn them that it cannot find this file.
Collaborator
There was a problem hiding this comment.
I commented only once but I think disable=SC1091 should be removed in both cases.
- Either people run shellcheck -x from the top-level directory as they should. in that case
disable=SC1091is not needed because shellcheck successfully includes the files. - Or, people forget
-xor run shellcheck from a different directory. Then, you want the first warning (out of many other warnings) to be "could not find include files". So, you don't wantdisable=SC1091there either because you don't want to lose the most important warning.
So you never want disable=SC1091
Contributor
Author
There was a problem hiding this comment.
thanks Marc, I agree
Collaborator
There was a problem hiding this comment.
Afraid disable=SC1091 came back :-(
It's in two other files as well.
arikgreen
force-pushed
the
awilczax/add-test-jack-detection-d3
branch
2 times, most recently
from
d676234 to
fd03264
Compare
arikgreen
force-pushed
the
awilczax/add-test-jack-detection-d3
branch
from
fd03264 to
04418c9
Compare
redzynix
reviewed
Nov 26, 2025
redzynix
reviewed
Nov 26, 2025
redzynix
reviewed
Nov 26, 2025
redzynix
reviewed
Nov 26, 2025
redzynix
requested changes
Nov 26, 2025
Contributor
redzynix
left a comment
redzynix
left a comment
There was a problem hiding this comment.
Some minor changes needed
arikgreen
force-pushed
the
awilczax/add-test-jack-detection-d3
branch
2 times, most recently
from
bfa8930 to
df930dd
Compare
Add a new test case to test jack detection during DSP is in D3 state. The test will check if the jack detection status is updated correctly when the jack is plugged in and unplugged and also if DSP status is changing correctly as well. For unplug/plug headset jack is using a USB relay. https://github.com/darrylb123/usbrelay Signed-off-by: Artur Wilczak <arturx.wilczak@intel.com>
arikgreen
force-pushed
the
awilczax/add-test-jack-detection-d3
branch
from
df930dd to
1a2f2a7
Compare
redzynix
approved these changes
Nov 27, 2025
PLangowski
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new test case to test jack detection during DSP is in D3 state.
The test will check if the jack detection status is updated correctly when the jack is plugged in and unplugged and also if DSP status is changing correctly as well.
For unplug/plug headset jack is using a USB relay.
https://github.com/darrylb123/usbrelay