trace: Use uncached memory in trace_point and panic

ktrzcinx · lgirdwood · commit fcf6c8c416f7 · 2019-11-22T14:16:33.000Z
It didn't work correctly if multiple cores write to "sw regs"
 allocated on the same cache line.

Signed-off-by: Karol Trzcinski &lt;karolx.trzcinski@linux.intel.com&gt;
diff --git a/src/include/sof/lib/mailbox.h b/src/include/sof/lib/mailbox.h
@@ -105,9 +105,11 @@ void mailbox_stream_write(size_t offset, const void *src, size_t bytes)
 static inline
 void mailbox_sw_reg_write(size_t offset, uint32_t src)
 {
-	*((volatile uint32_t*)(MAILBOX_SW_REG_BASE + offset)) = src;
-	dcache_writeback_region((void *)(MAILBOX_SW_REG_BASE + offset),
-				sizeof(src));
+	volatile uint32_t *ptr;
+
+	ptr = (volatile uint32_t *)(MAILBOX_SW_REG_BASE + offset);
+	ptr = cache_to_uncache(ptr);
+	*ptr = src;
 }
 
 #endif /* __SOF_LIB_MAILBOX_H__ */

Original file line number	Diff line number	Diff line change
`@@ -105,9 +105,11 @@ void mailbox_stream_write(size_t offset, const void *src, size_t bytes)`
`105`	`105`	`static inline`
`106`	`106`	`void mailbox_sw_reg_write(size_t offset, uint32_t src)`
`107`	`107`	`{`
`108`		`- ((volatile uint32_t)(MAILBOX_SW_REG_BASE + offset)) = src;`
`109`		`- dcache_writeback_region((void *)(MAILBOX_SW_REG_BASE + offset),`
`110`		`- sizeof(src));`
	`108`	`+ volatile uint32_t *ptr;`
	`109`	`+`
	`110`	`+ ptr = (volatile uint32_t *)(MAILBOX_SW_REG_BASE + offset);`
	`111`	`+ ptr = cache_to_uncache(ptr);`
	`112`	`+ *ptr = src;`
`111`	`113`	`}`
`112`	`114`
`113`	`115`	`#endif /* __SOF_LIB_MAILBOX_H__ */`