topology2: add deep buffer speaker support to amp function topologies#10538
Merged
kv2019i merged 3 commits intothesofproject:mainfrom Feb 13, 2026
Merged
topology2: add deep buffer speaker support to amp function topologies#10538kv2019i merged 3 commits intothesofproject:mainfrom
kv2019i merged 3 commits intothesofproject:mainfrom
Conversation
The existing code assumes that deep buffer jack is always there if deep buffer is enabled. But amp function topology only needs deep buffer speaker. Split deep buffer speaker from the deep-buffer.conf will make us be easier to add deep buffer speaker into the amp function topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
Adds deep-buffer speaker support to SDCA amp function topologies by enabling deep-buffer flags in production targets and refactoring the speaker deep-buffer pipeline into a reusable include.
Changes:
- Enable deep-buffer speaker flags for
sof-sdca-{1..4}amp-id2production target strings. - Conditionally include a new
deep-buffer-spk.conffrom SDW amp generic config when deep-buffer speaker mode is enabled. - Refactor
deep-buffer.confto include speaker pipeline from the newdeep-buffer-spk.conffile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-sdca-generic.cmake | Enables deep-buffer speaker mode parameters for SDCA amp target variants. |
| tools/topology/topology2/platform/intel/sdw-amp-generic.conf | Adds conditional include logic to pull in deep-buffer speaker config for SDW amp topologies. |
| tools/topology/topology2/platform/intel/deep-buffer.conf | Replaces embedded speaker deep-buffer pipeline with an include of deep-buffer-spk.conf. |
| tools/topology/topology2/platform/intel/deep-buffer-spk.conf | Introduces a standalone deep-buffer speaker pipeline + PCM definition for reuse. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
27
| #deep-buffer-spk.conf is included in deep-buffer.conf | ||
| #and deep-buffer.conf is included if SDW_JACK is true |
There was a problem hiding this comment.
These comments are confusing in this context because this branch explicitly checks SDW_JACK is "false" and includes deep-buffer-spk.conf directly. Consider rewriting the comment to explain the actual behavior here (e.g., “deep-buffer-spk.conf is normally pulled via deep-buffer.conf when SDW_JACK=true; for SDW amp topologies with SDW_JACK=false we include it directly here”).
Suggested change
| #deep-buffer-spk.conf is included in deep-buffer.conf | |
| #and deep-buffer.conf is included if SDW_JACK is true | |
| # deep-buffer-spk.conf is normally pulled in via deep-buffer.conf | |
| # when SDW_JACK=true; for SDW amp topologies with SDW_JACK=false | |
| # we include deep-buffer-spk.conf directly here. |
lgirdwood
reviewed
Feb 11, 2026
Comment on lines
26
to
27
| #deep-buffer-spk.conf is included in deep-buffer.conf | ||
| #and deep-buffer.conf is included if SDW_JACK is true |
Include deep-buffer-spk.conf if DEEP_BUF_SPK is true and SDW_JACK is false. deep-buffer-spk.conf is only included when SDW_JACK is false because deep-buffer-spk.conf is already included in deep-buffer.conf when SDW_JACK is true. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add deep buffer speaker support to amp function topologies Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
deep-buf-spk
branch
from
b6e9f65 to
96bcd1c
Compare
ranj063
approved these changes
Feb 12, 2026
kv2019i
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deep buffer speaker support to amp function topologies