rimage: manifest: Make "cold" section size 0 when not used

[dbaluta]

There are some non-critical data and code sections that are kept in DRAM to be accessed and executed from there without being copyind to SRAM.

Such sections are marked as detached and linked into a separate "cold.mod" module.

rimage considers zones starting at SOF_MODULE_DRAM_LINK_START to SOF_MODULE_DRAM_LINK_END to be cold and links them separately.

On i.MX8MP for M7 support this overalps with ITCM/DTCM/OCRAM areas which causes boot problems.

So, treat all sections as SRAM when CONFIG_COLD_STORE_EXECUTE_DRAM is not enabled by making DRAM link sections size equal to 0 in this case.

Closes: #10602

[Copilot]

Pull request overview

This PR fixes a boot problem on i.MX8MP (M7) where ITCM/DTCM/OCRAM memory sections were incorrectly treated as "detached" (cold/DRAM) by rimage, causing them to be omitted from the output image. The fix makes SOF_MODULE_DRAM_LINK_END equal to SOF_MODULE_DRAM_LINK_START (both 0) when CONFIG_COLD_STORE_EXECUTE_DRAM is not enabled, effectively collapsing the DRAM link range to empty and ensuring all sections are treated as SRAM.

Changes:

• When CONFIG_COLD_STORE_EXECUTE_DRAM is disabled, SOF_MODULE_DRAM_LINK_END is defined as SOF_MODULE_DRAM_LINK_START (0), making the DRAM detection range empty.
• When CONFIG_COLD_STORE_EXECUTE_DRAM is enabled, behavior is unchanged (SOF_MODULE_DRAM_LINK_END = 0x08000000).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment block above SOF_MODULE_DRAM_LINK_START (lines 253–258) only accurately describes the behavior when CONFIG_COLD_STORE_EXECUTE_DRAM is enabled. After this change, when the config is not enabled, SOF_MODULE_DRAM_LINK_END equals SOF_MODULE_DRAM_LINK_START (i.e., 0), making the DRAM link range empty and disabling detached-section treatment entirely. The comment should be updated to reflect this conditional behavior — for example, noting that when CONFIG_COLD_STORE_EXECUTE_DRAM is not set, the range is empty and no sections are treated as detached.

[lyakh]

@dbaluta The change looks good, but CI fails, and I think I know why. That header that you're modifying is also included for rimage build and there CONFIG_COLD_STORE_EXECUTE_DRAM isn't set. So you need to modify your condition to something like #if CONFIG_COLD_STORE_EXECUTE_DRAM || !CONFIG_ZEPHYR_SOF_MODULE - you should be able to build test it (including rimage of course) for PTL too
UPDATE: but then it will break rimage for you again... Maybe rimage build should also include autoconf.h but that might be a bit more difficult...
UPDATE 2: this would be a bit controversial because we would prefer to have a single rimage executable for all architectures, but in a way this is already not the case: those DRAM start and end addresses are clearly architecture specific

[dbaluta]

@lyakh oh this is so unfortunate. Yes, I would also prefer same rimage for all architectures. Maybe add a runtime parameter to ignore detached sections.