ci: cover template overlays in CLI install/build e2e - #1152
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
ci: cover template overlays in CLI install/build e2e#1152devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ocal templates in CI Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLI End to Endonly ever scaffolded the default overlay, so overlay dependency sets (LangGraph, Vercel AI SDK, Vercel Eve) and their lockfile handling increate-appwere never installed or built in CI. This adds overlay coverage without multiplying the existing 26-job OS × package-manager matrix by 4.The new jobs immediately caught two real problems, fixed here:
openui-cloud'svercel-eveoverlay failednext build— its tsconfig was missing theallowImportingTsExtensions/exclude: ["agent"]that the self-hosted overlay has, soagent/tools/get_weather.ts(which imports../../src/lib/tools/get-weather.tsby design, for Eve's ESM module map) trippedTS5097.checkoutSource/fetchSourceFilealways fetchthesysdev/openui@main, so a PR touchingtemplates/**ran its CLI againstmain's templates.Changes
.github/actions/cli-scaffold-e2e, parameterized bytemplate,backend-framework,node-version,package-manager,package-manager-version. The CLI invocation now always passes--backend-framework.cli-e2e-overlaysjob:{openui-cloud, openui-self-hosted} × {langgraph, vercel-ai-sdk, vercel-eve} × {npm, pnpm}= 12 jobs on ubuntu / Node 24 / package-manager major 11. Overlays only change dependencies and app code, so the OS and package-manager-major spread stays on the default overlay (cli-e2e, unchanged in coverage).OPENUI_SOURCE_DIRenv var makescheckoutSource/fetchSourceFileread templates andtemplates.jsonfrom a local source checkout instead of GitHubmain; the composite action sets it togithub.workspaceso the jobs test the commit under test. Unset (i.e. for users) behavior is unchanged.templates/openui-cloud/overlays/vercel-eve/tsconfig.json: addedallowImportingTsExtensionsand excludedagent, matching the self-hosted overlay.pathsfilters now include the composite action.Note the composite action forces
shell: bashfor the run steps (composite steps must declare a shell); on the Windows jobs those steps previously defaulted to pwsh.Not touched:
cli-template-package-managers.yml, which diffs resolved deps of the template directories themselves — overlays are not standalone installable directories, so that one has no overlay analogue.Test Plan
actionlintcleanopenui create --template openui-cloud --backend-framework vercel-evewithOPENUI_SOURCE_DIRpointing at the checkout: scaffold +npm install+next buildall pass with the tsconfig fix (this also exercises the new local-source path)Checklist
Link to Devin session: https://app.devin.ai/sessions/c594d3982aa447a39e419b32bdea004a
Open in Devin Desktop: https://app.devin.ai/desktop/session/c594d3982aa447a39e419b32bdea004a?variant=devin