Make lang-core runtime telemetry opt-in - #991
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
vishxrad
approved these changes
Aug 17, 2026
Aditya-thesys
added a commit
to Aditya-thesys/noetic
that referenced
this pull request
Aug 25, 2026
0.2.15 makes runtime telemetry opt-in (thesysdev/openui#991): Library.prompt(), used by systemPrompt(), sends nothing and runs no git lookup unless the consumer sets OPENUI_RUNTIME_TELEMETRY_ENABLED=1. This resolves the runtime half of the telemetry review; the postinstall event remains opt-out upstream. 0.2.15 also adds a `type-mismatch` parse error code that catches literal props of the wrong type at parse time. fromParseError maps it to Noetic's own `prop '<name>' rejects: …` wording so validation output stays stable across lang-core prose changes, and a regression test covers it. Exact pins per repo convention; example client lockfile regenerated. openui suite 63/0, repo 2183/0, lint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016FnULcG1A36u7uMpQGkC3r Signed-off-by: Aditya-thesys <aditya@thesys.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Runtime usage telemetry in
@openuidev/lang-core(the sampledgenerateSystemPrompt()event) was opt-out — it sent unlessOPENUI_TELEMETRY_DISABLED/DO_NOT_TRACKwas set. Per request in Slack, it is now opt-in: nothing is sent unless the user explicitly setsOPENUI_RUNTIME_TELEMETRY_ENABLED=1.Installation (
postinstall) telemetry is unchanged, as is the CLI's--no-telemetry/DO_NOT_TRACKbehavior.Changes
telemetry/shared.ts: newisRuntimeTelemetryEnabled(env)=OPENUI_RUNTIME_TELEMETRY_ENABLEDtruthy AND not disabled (soOPENUI_TELEMETRY_DISABLED/DO_NOT_TRACKstill win).telemetry/runtime.ts:recordSystemPromptGenerationreturns early unlessisRuntimeTelemetryEnabled(env); disclosure comment notes the opt-in.packages/lang-core/README.md: documents the opt-in env var.Test Plan
pnpm --filter @openuidev/lang-core lint:check,build, andtest(76 passing) all green. Behavior is a single guard flip; no telemetry tests exist in the package.Checklist
Link to Devin session: https://app.devin.ai/sessions/d4242685cb1e4daa9a42d4fdea3cf8d5
Requested by: @zahlekhan