Open
Conversation
The first time the Message Banner is shown it slides in from an arbitrary position at the top left. As far as I can tell this is due to the constraints being applied outside of the animation block. Also setting `currentMessageBanner.center = target` is really not needed as this is using constraints which override setting the center anyway. I would drop setting `currentMessageBanner.center = target` as well as `calculateTargetCenter:` altogether except that there are side effects in `calculateTargetCenter:` which are needed.
Owner
|
Thanks for the PR, il will merge a rework the center value during this weekend. |
|
Awesome! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time the Message Banner is shown it slides in from an arbitrary position at the top left. As far as I can tell this is due to the constraints being applied outside of the animation block.
Also setting
currentMessageBanner.center = targetis really not needed as this is using constraints which override setting the center anyway. I would drop settingcurrentMessageBanner.center = targetas well ascalculateTargetCenter:altogether except that there are side effects incalculateTargetCenter:which are needed.